Fix example test suites without result generated by testing/codegen#216
Merged
Conversation
in testing/codegen.
generated by testing/codegen.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes example test suites without result generated by testing/codegen by ensuring proper handling of methods that return results versus those that don't. The changes update the test template generation to conditionally handle result variables and add comprehensive test coverage for both scenarios.
- Consolidated template logic to handle both result and non-result methods in a single line
- Added test data with examples for both with-result and without-result service scenarios
- Created comprehensive test suite to verify correct generation for both method types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| testing/codegen/testdata/code.go | Added test data constants for with-result and without-result service harness code |
| testing/codegen/templates/suite_test.go.tpl | Simplified template to conditionally handle result variables based on method signature |
| testing/codegen/suite_test.go | Added comprehensive test suite to verify correct suite generation for both method types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
This is great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.